Variable expansion related cleanup for man pages and sysv init

etc/dkimpy-milter.conf

@@ -1,6 +1,5 @@
 # This is a basic configuration that can easily be adapted to suit a standard
-# installation. For more advanced options, see dkimpy-milter.conf(5) and/or
+# installation. For more advanced options, see dkimpy-milter.conf(5).
-# /usr/share/doc/dkimpy-milter/examples/opendkim.conf.sample.
 
 # Log to syslog
 Syslog			yes
@@ -19,8 +18,6 @@ UMask			007
 #Canonicalization	relaxed/simple
 #Mode			sv
 
-# Socket local:/run/dkimpy-milter/dkimpy-milter.sock
-#
 # ##  Socket socketspec
 # ##
 # ##  Names the socket where this filter should listen for milter connections
@@ -30,6 +27,8 @@ UMask			007
 # ##  inet:port                   to listen on all interfaces
 # ##  local:/path/to/socket       to listen on a UNIX domain socket
 #
+#Socket local:/run/dkimpy-milter/dkimpy-milter.sock
+#
 #Socket			inet:8892@localhost
 
 ##  PidFile filename

etc/dkimpy-milter.conf.in

@@ -1,6 +1,5 @@
 # This is a basic configuration that can easily be adapted to suit a standard
-# installation. For more advanced options, see dkimpy-milter.conf(5) and/or
+# installation. For more advanced options, see dkimpy-milter.conf(5).
-# /usr/share/doc/dkimpy-milter/examples/opendkim.conf.sample.
 
 # Log to syslog
 Syslog			yes
@@ -19,8 +18,6 @@ UMask			007
 #Canonicalization	relaxed/simple
 #Mode			sv
 
-# Socket local:@RUNSTATEDIR@/dkimpy-milter.sock
-#
 # ##  Socket socketspec
 # ##
 # ##  Names the socket where this filter should listen for milter connections
@@ -30,6 +27,8 @@ UMask			007
 # ##  inet:port                   to listen on all interfaces
 # ##  local:/path/to/socket       to listen on a UNIX domain socket
 #
+#Socket local:@RUNSTATEDIR@/dkimpy-milter.sock
+#
 #Socket			inet:8892@localhost
 
 ##  PidFile filename

system/dkimpy-milter

@@ -18,10 +18,8 @@
 # Short-Description: dkimpy-milter
 # Description:       Python DKIM Milter for Sendmail and Postfix
 ### END INIT INFO
-prefix="/usr/local"
+sysconfdir="/usr/local/etc/dkimpy-milter"
-exec_prefix=${prefix}
+bindir="/usr/local/bin"
-sysconfdir="/usr/local/etc"
-bindir="${exec_prefix}/bin/"
 RUNDIR="/run/dkimpy-milter"
 DAEMON=${bindir}/dkimpy-milter
 PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:

system/dkimpy-milter.in

@@ -33,8 +33,8 @@ test -x $DAEMON || exit 0
 
 # Include dkimpy-python defaults if available
 # Typically not used
-if [ -f @SYSCONFDIR@/default/dkimpy-milter ] ; then
+if [ -f $sysconfdir/default/dkimpy-milter ] ; then
-	. @SYSCONFDIR@/default/dkimpy-milter
+	. $sysconfdir/default/dkimpy-milter
 fi
 
 set -e
@@ -65,14 +65,14 @@ case "$1" in
 			fi
 		fi
 	fi
-
+        start-stop-daemon --start --background --quiet --pidfile \
-        start-stop-daemon --start --quiet --pidfile $RUNDIR/$NAME.pid --startas \
+                $RUNDIR/$NAME.pid --exec $DAEMON $sysconfdir/$NAME.conf
-                $DAEMON $sysconfdir/$NAME.conf --name $NAME --test > /dev/null \
 	echo "$NAME."
 	;;
   stop)
 	echo -n "Stopping $DESC: "
 	if [ -f $RUNDIR/$NAME.pid ]; then
+		chown root:root $RUNDIR/$NAME.pid
 		start-stop-daemon --stop --pidfile $RUNDIR/$NAME.pid 
 		rm $RUNDIR/$NAME.pid
 		#echo $SOCKET
@@ -85,6 +85,7 @@ case "$1" in
   force-reload)
         echo -n "Force reloading $DESC: "
         if [ -f $RUNDIR/$NAME.pid ]; then
+                chown root:root $RUNDIR/$NAME.pid
                 start-stop-daemon --stop --pidfile $RUNDIR/$NAME.pid
                 rm $RUNDIR/$NAME.pid
                 #echo $SOCKET
@@ -93,7 +94,7 @@ case "$1" in
                 fi
         fi
         sleep 1
-        start-stop-daemon --start --chuid $USER --background --quiet --pidfile \
+        start-stop-daemon --start --background --quiet --pidfile \
                 $RUNDIR/$NAME.pid --exec $DAEMON $sysconfdir/$NAME.conf
         echo "$NAME."
         ;;
@@ -101,6 +102,7 @@ case "$1" in
         echo "Restarting $DESC: "
         echo -n "Stopping $DESC: "
         if [ -f $RUNDIR/$NAME.pid ]; then
+                chown root:root $RUNDIR/$NAME.pid
                 start-stop-daemon --stop --pidfile $RUNDIR/$NAME.pid
                 rm $RUNDIR/$NAME.pid
                 #echo $SOCKET
@@ -111,7 +113,7 @@ case "$1" in
         echo "$NAME."
 	sleep 1
         echo -n "Starting $DESC: "
-        start-stop-daemon --start --chuid $USER --background --quiet --pidfile \
+        start-stop-daemon --start --background --quiet --pidfile \
                 $RUNDIR/$NAME.pid --exec $DAEMON $sysconfdir/$NAME.conf
         echo "$NAME."
 	;;