DandelionNStuff/dkimpy-milter-smtputf8
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor ExceptHook to get rid of archaic string usage and restore reporting to stderr.

Browse Source
This commit is contained in:
Scott Kitterman
2018-02-14 07:20:54 -05:00
parent 19ac561822
commit 92923fdbc4
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dkimpy_milter/util.py
+4 -5
View File
@@ -51,7 +51,6 @@ def drop_privileges(milterconfig):
old_umask = os.umask(milterconfig.get('UMask')) old_umask = os.umask(milterconfig.get('UMask'))
################# #################
# FIXME - still uses string, refactor
class ExceptHook: class ExceptHook:
def __init__(self, useSyslog = 1, useStderr = 0): def __init__(self, useSyslog = 1, useStderr = 0):
self.useSyslog = useSyslog self.useSyslog = useSyslog
@@ -59,14 +58,14 @@ class ExceptHook:
def __call__(self, etype, evalue, etb): def __call__(self, etype, evalue, etb):
import traceback import traceback
import string import sys
tb = traceback.format_exception(*(etype, evalue, etb)) tb = traceback.format_exception(*(etype, evalue, etb))
tb = map(string.rstrip, tb) for line in tb:
tb = string.join(tb, '\n')
for line in string.split(tb, '\n'):
if self.useSyslog: if self.useSyslog:
import syslog import syslog
syslog.syslog(line) syslog.syslog(line)
if self.useStderr:
sys.stderr.write(line)
#################### ####################