bd1d25d83e
Set up correct AuthservID defaults
...
Without this fix, a verifying dkimpy-milter that has no explicit
AuthservID produces the following crashing behavior as it tries to
create the authres header:
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/Milter/__init__.py", line 772, in <lambda>
milter.set_eom_callback(lambda ctx: ctx.getpriv().eom())
File "…/dkimpy_milter/__init__.py", line 199, in eom
h = fold(str(h))
File "/usr/lib/python2.7/dist-packages/authres/core.py", line 476, in __str__
return ''.join((self.HEADER_FIELD_NAME, ': ', self.header_value()))
File "/usr/lib/python2.7/dist-packages/authres/core.py", line 496, in header_value
return ''.join(strs)
2019-02-21 19:21:38 -05:00
1c6030024d
add DNSOverride configuration for testing
2019-02-21 19:21:38 -05:00
71c0c3f20a
Avoid failing to chown non-existent Unix-domain sockets
...
Changing ownership of sockets that doesn't exist isn't a great
practice.
A better approach would be to apply os.chown() to the file descriptor
of the open socket, but at the very least dkimpy-milter shouldn't
crash the way it currently does if the socket isn't already present.
2019-02-21 19:21:38 -05:00
a9a6893c89
Handle unix: socket prefix the same as local:
...
sendmail's milter.c treats these two declarations the same way, so
what we do for one should also be done for the other.
2019-02-21 19:21:38 -05:00
bb44f36519
When Socket is absolute path, do not strip leading /
...
This appears to just be an untested codepath.
2019-02-21 19:21:38 -05:00
9e11b75ec3
Avoid AttributeError on simple connection and disconnection
...
Without this patch, this simple script for miltertest:
----
conn = mt.connect("unix:milter.sock")
if conn == nil then
error "mt.connect() failed"
end
if mt.conninfo(conn, nil, "unspec") ~= nil then
error "mt.conninfo() failed"
end
if mt.getreply(conn) ~= SMFIR_CONTINUE then
error "mt.conninfo() unexpected reply"
end
mt.disconnect(conn)
----
Produces the following error:
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/Milter/__init__.py", line 702, in connect_callback
return m.connect(hostname,family,hostaddr)
File "/usr/lib/python2.7/dist-packages/Milter/__init__.py", line 173, in wrapper
rc = func(self,*args)
File "/home/dkg/src/dkimpy-milter/dkimpy-milter/dkimpy_milter/__init__.py", line 64, in connect
self.receiver = self.getsymval('j').strip()
AttributeError: 'NoneType' object has no attribute 'strip'
2019-02-21 19:21:38 -05:00
f60ea12e86
Prefer dnspython over PyDNS in setup.py
...
README and dkimpy_milter/dnsplug.py both prefer dnspython if
available, over PyDNS. setup.py should order the preferences in the
same way.
2019-02-21 19:21:36 -05:00
e872bd44b0
ignore emacs turds
2019-02-19 18:03:54 -05:00
51c8fdcb6c
Bump version to 1.0.1, update TODO, set release date
2019-02-11 15:14:11 -05:00
aa4dadc22f
* Reorder milter start and dropping privileges so permissions on Unix socket
...
are correct (LP: 1797720)
2019-02-11 15:09:34 -05:00
b1abbf9d61
- Make domain checks case insensitive for determining if signing should be
...
done (LP: #1815311 )
2019-02-11 14:55:35 -05:00
ea2b612e8d
- Add information on Ed25519 key creation to README (LP: #1815313 )
2019-02-11 14:23:55 -05:00
5945e818ca
- Add additional Sendmail configuration information to README from OpenDKIM
...
update based on input from Дилян Палаузов (LP: #1801619 )
2019-02-11 13:32:37 -05:00
f38fed3bee
Rip out unused whichbd module in preparation for python3 port
2019-02-11 03:16:53 -05:00
06948b3dbc
Update references in man/dkimpy-milter.8
2019-02-09 22:20:01 -05:00
e951ab6c5e
Remove obsolete .IX macro from man pages
...
Conflicts:
man/dkimpy-milter.conf.5
2019-02-09 22:19:41 -05:00
03c86a2b08
Fix grammar error in README
2019-02-09 22:18:11 -05:00
2cda1758c1
Fix spelling error in README
2019-02-09 22:17:53 -05:00
851f8ff9c9
Update references in man/dkimpy-milter.8
2019-02-08 04:02:34 -05:00
cbb6098dd8
Remove obsolete .IX macro from man pages
2019-02-08 01:12:21 -05:00
c90d694fff
Fix grammar error in README
2019-02-01 15:15:50 -05:00
8d8cd15cba
Fix spelling error in README
2019-02-01 15:11:00 -05:00
4f21623f92
Add read_keytable function to util.py
2018-12-24 16:08:50 -05:00
bf2548f891
Documentation updates for 1.1.0
2018-10-11 21:45:17 -04:00
a188bd3960
Deleted reference to obsolete syslog target in unit file
2018-05-11 14:31:15 -04:00
c91a12f0d1
Documentation updates for 1.0.0 release
2018-05-11 14:29:15 -04:00
286ffbb6c9
Add release date for 0.9.7 to CHANGES
2018-03-19 01:07:52 -04:00
ec3252c367
- Minor sysv init improvments
2018-03-15 23:59:03 -04:00
a2ff03727d
- Put version directly in setup.py and do not import dkimpy_milter to ease
...
install via pip
2018-03-15 23:44:31 -04:00
af4b05e242
- Add missing documentation key to system/dkimpy-milter.service
2018-03-15 20:49:35 -04:00
6509eaad35
- Made sysv init executable
2018-03-15 20:44:16 -04:00
f9483fea8c
- Added protection for malformed From addresses. If the From does not at
...
least have an '@' in the address, then the signing domain is not extracted
and the message will not be signed
2018-03-15 20:42:49 -04:00
7a3a7bfb43
Bump version to 0.9.6
2018-03-12 22:08:07 -04:00
8a0e1bdd97
- Fixed typo in path for fallback location of the config file if one is not
...
provided
2018-03-12 22:03:45 -04:00
e3005aa723
Move OversignHeaders up earlier on TODO.
2018-03-12 22:03:36 -04:00
45d3ba13ca
Added more to README about first run with systemd
2018-03-11 00:42:22 -05:00
f05309437f
Fix merge conflict
2018-03-11 00:28:08 -05:00
d4499f6990
Fixed typo in package installation section of README
2018-03-11 00:27:19 -05:00
7d87309f4b
Fixed typo in package installation section of README
2018-03-11 00:24:39 -05:00
1d8c309da9
Fix setup.py install locations so they are installed correctly and drop unneeded README changes.
2018-03-10 20:06:21 -05:00
4d5961e4d5
Bump version
2018-03-10 19:52:29 -05:00
59448e8e57
- Add information to README about manually putting init scripts in the right
...
locations
2018-03-10 19:51:29 -05:00
695de0db14
- Add conf file location to systemd unit file
2018-03-10 19:43:37 -05:00
dfd6fa68c3
Changelog: release 0.9.5 (Beta 1)
2018-03-10 19:06:55 -05:00
86eb152f93
Enhanced signature verification logging to provide more useful information, added signing success logging, and more PEP 8
2018-03-10 19:02:37 -05:00
126966e110
- Update Authentication Results result comment not to mention key size for
...
ed25519 signatures, since it's irrelevant
2018-03-10 18:18:01 -05:00
5d8d47cd52
- Fixed install_requires so either dnspython (preferred if neither is
...
installed) or PyDNS satisfies the install requirements
2018-03-10 17:49:22 -05:00
1843ca6244
- Added support for SyslogSuccess option
...
- Rationalized logging to be much less verbose unless SyslogSuccess or
debugLevel are set - default is generally start/stop/errors only
2018-03-10 16:06:22 -05:00
f9358d594c
Delete unused import
2018-03-10 15:36:40 -05:00
a8aa422b03
Post pep-8 cleanup
2018-03-10 15:34:56 -05:00
Daniel Kahn Gillmor