43c91feac6
Document content debugging parameter.
2018-12-31 09:17:53 -05:00
4175d75534
Merge remote-tracking branch 'upstream/master' into content_debugging
2018-12-31 09:10:24 -05:00
25b2eb72b2
Merge remote-tracking branch 'jbfzs/beautifold'
2018-12-23 01:54:39 -05:00
6b4127f920
Don't insert an extra space at the end of the line when doing a soft fold.
...
Trailing whitespaces are best avoided.
2018-12-12 21:30:56 -05:00
2d474d6b04
Do not take the name length into account on the second line when folding.
...
Setting namelen could have no effect, my guess is that this was the
original intention of the code.
This results in more efficient usage of lines.
2018-12-12 21:14:08 -05:00
82bef5983b
Don't log message content by default.
...
Right now, it is quite easy to end up logging the whole message in the
log when verifying signatures. This can result in wasted resources
writing the log to disk and increasing memory usage. This can also be
a private data leak if logging is put in DEBUG in a production
environment.
2018-12-12 15:30:47 -05:00
882d14c514
Avoid making a fresh slice of the whole email on each iteration.
...
An update to yesterday's patch. Should avoid copying the mail byte
string more than once.
Tested on Python 2.7 and 3.6.
2018-12-12 13:41:48 -05:00
7dee16a5b1
Refactor canonicalization.py strip_trailing_lines to avoid using re for more consistent processing across python versions
2018-12-11 14:34:34 -05:00
72f58200e3
- Refactored dknewkey so that it correctly writes out text instead of bytes
2018-12-08 17:32:56 -05:00
c3eb342611
Fixed ARC verification to fail is h= tag is present in Arc-Seal, added test, bumped version to start 0.9.1
2018-11-09 19:58:11 -05:00
267e62115e
- Added missing documentation for timestamp function dkim.arc_sign
...
(LP: #1800314 )
2018-10-30 11:52:43 -04:00
09d4c3d84d
Fix @since for add_should_not
2018-10-30 11:40:20 -04:00
8032276b57
Bump version to 0.9.0 since this is now a feature release
...
- Update oversigned (frozen) header field list to reduce signature
fragility (removes 'date' and 'subject' fields from being oversigned by
default - see usage section of README for information on how to restore
the previous behavior)
- Added new add_should_not for DKIM/ARC classes to prevent additional
header fields from being signed
- Added 'from' to should sign list (to prevent it from not being signed at
all in the unusual event that 'from' is locally removed from the frozen
header field set (LP: #1525048 )
- Updates for experimental ARC support:
- Specified that for ARC, Authentication-Results should not be signed
2018-10-30 11:29:09 -04:00
82d01d8a42
- Raise error when ARC signing if i= instance limit value of 50 is
...
exceeded
2018-10-30 08:55:32 -04:00
cd0ebc1ecb
- Updates for experimental ARC support:
...
- Limit to rsa-sha256, rsa-sha1 not used by ARC and multi-signature
design TBD
2018-10-30 08:13:06 -04:00
5349a9f813
Add support for EAI addresses in domains and selectors (John Levine)
2018-10-29 21:55:12 -04:00
3c2beaf70e
- Python 3.7 compatibility fixup for dkim.canonicalization.
...
strip_trailing_lines due to changed RE.sub() processing (LP: #1800313 )
2018-10-29 19:53:12 -04:00
4142cd1bd0
lack of Type Hinting for sign and verify functions, lp:1782596
2018-10-27 20:56:05 -04:00
a1ca321fa5
PEP8 Blank Lines Style Issues, lp:1782596
2018-10-27 20:53:32 -04:00
f8deb49c0d
Don't error out in Python 3 if include headers is string (LP: #1776775 )
2018-06-16 18:18:45 -04:00
906980f57a
tests: fix DeprecationWarnings for assertEquals
2018-06-16 17:28:10 -04:00
0338aedcc6
Fix bare except statements for expected ImportErrors
2018-06-16 17:28:02 -04:00
0566b9b4c1
- Correctly fold lines at or near the maximum line length (fix folding
...
zero length lines and adding a blank line and adding an exra cr/lf for
lines near max length (LP: #1717576 )
2018-06-16 16:59:39 -04:00
ef80f037ca
Delete unused test data
2018-06-09 22:07:02 -04:00
3a68a64836
Update tests so that both RSA and Ed25519 verifying test verifying dual signed message.
2018-06-02 01:19:24 -04:00
d5c4f69b27
Remove obsolete and incorrect test data
2018-06-02 01:04:29 -04:00
a0ae8c24c5
Detect unknown algorithm in k= tag and raise an appropriate error, vice
...
failing with a traceback
2018-05-18 19:42:46 -04:00
92608e79c4
Simplify error message for bad version (match what Google does)
2018-05-18 18:21:32 -04:00
bec6869c78
Detect incorrect version in DKIM public key record (LP: #1763815 )
2018-05-18 18:17:30 -04:00
261eb5f5eb
Add test for detecting bad version number in DKIM txt record
2018-05-18 17:04:50 -04:00
e50d3907ae
Fixup script structure for entrypoints
2018-03-26 03:35:03 -04:00
d860dfd51e
Switch to setuptools/entrypoints from distutils/scripts
2018-03-25 22:39:20 -04:00
1cafbe7e03
Remove debug print statements in test suite
2018-02-17 13:56:47 -05:00
9f9fe2625b
Add another RFC data based test
2018-02-12 13:45:26 -05:00
43e56378c1
- Return an empty list (as expected) when no AR headers are found or no AR
...
arc stamps are found and the chain terminated (LP: #1748146 )
2018-02-11 19:39:51 -05:00
1ac948299e
Delete stray print
2018-02-11 19:29:53 -05:00
d097a5f523
- Update ed25519 tests, including using sample keys from RFC 8032 Section
...
7.1 and the sample message from RFC 6376
2018-02-11 19:26:04 -05:00
6bbbdf9b22
Update test data and test harness for test_verify_third_party - now it passes
2018-02-05 13:43:19 -05:00
3209be62d1
Fix a= tag in ed25519 signatures (thanks to Jeremy Harris)
2018-02-05 11:28:05 -05:00
3138f90077
Updated copyright statements
2018-02-05 04:05:41 -05:00
077bf4813c
Self consistent, but not externally verified ed25519 based on draft-ietf-dcrup-dkim-crypto-08
2018-02-05 03:53:03 -05:00
10e12c60d8
- Fix unbound local variable error when processing signatures with an x
...
tag, but no t tag (LP: #1739637 )
2017-12-21 16:35:42 -05:00
0c6fdbf7c6
- Add new test, test_implicit_k, to verify that RSA processing is still
...
correct when the optional k= tag is not present in the DKIM public key
record
2017-11-30 14:33:01 -05:00
16f5bd693c
Fix empty body canonicalization for relaxed canonicalization (LP: #1727319 )
2017-11-21 07:13:01 -05:00
5f5873c1fd
Fixed ARC tests
2017-11-20 20:53:32 -08:00
44146ed2de
Fix arcverify tag requirements (LP: #1710312 )
2017-11-18 23:34:50 -05:00
04b1a8dddf
Reapply lost ARC updates
2017-11-18 20:38:47 -05:00
01a2f77481
Revert a bunch of rsafp stuff now that DCRUP isn't going to do rsafp
2017-11-18 20:17:35 -05:00
6de4fa79cd
Fix relaxed body canoncalization & introduce further unit tests for both simple and relaxed mode
2017-10-25 13:06:00 +01:00
3f9660716e
Delete unused sys import
2017-07-28 01:32:25 -04:00
Jonathan Bastien-Filiatrault