Commit Graph
100 Commits
Author SHA1 Message Date
Scott Kitterman 8cf323d4ea Confine errors from dnspython to dnsplug and use dkim errors, since dkim.__init__.py doesn't import dns and needs dkim errors (LP: #2018646) 2023-05-12 01:13:46 -04:00
Scott Kitterman c75fa31ad2 Bump version to 1.1.4 2023-05-07 14:38:02 -04:00
Scott Kitterman 4a5c1e0393 Add release date 2023-04-30 09:49:41 -04:00
Scott Kitterman dd650da4f0 Properly cleanup temporary directories in tests 2023-04-30 09:47:26 -04:00
Scott Kitterman 7262f53687 Update documentation in README.md on handling private keys 2023-04-30 09:31:09 -04:00
Scott Kitterman 810d543085 Create ed25519 key files with secure permissions to avoid risk of insecure chmode call/race condition (LP: #2017430) 2023-04-30 09:25:28 -04:00
Scott Kitterman 2fc00b0218 Catch nacl.exceptions.ValueError and raise KeyFormatError, similar to how RSA key errors are treated (LP: #2018021) 2023-04-29 00:09:14 -04:00
Scott Kitterman 339bf1fb63 Bump version to 1.1.3 2023-04-28 23:41:49 -04:00
Scott Kitterman 5cedcb46d5 Release 1.0.2 2023-04-09 09:33:53 -04:00
Scott Kitterman 835a890007 Bump version to 1.1.2 2023-03-31 13:08:19 -04:00
Scott Kitterman 71119c956e Finalize 1.1.1 release 2023-03-10 11:18:05 -05:00
Scott Kitterman dd6bbd4c88 - Fix traceback when attempting to verify an unsigned message using
async verify (Thanks to Nikita Sychev for the report and a suggested
      fix) (LP: #2008723)
2023-02-28 00:02:07 -05:00
Scott Kitterman bf5ab32d55 Bump version to 1.1.1 and document python2 is no longer supported (LP: #2008738) 2023-02-27 23:49:56 -05:00
Scott Kitterman 59e9dd2cb5 Correct base64 validation regexp so that valid signature with == split
between two lines are not incorrectly evaluated as invalid (LP:
      #2002295) - Thanks to <https://launchpad.net/~obadz> for the report and
      the proposed fix
2023-02-25 17:16:53 -05:00
Scott Kitterman 2115a5e9f8 Invalid Authentication-Results header fields are ignored for ARC signing
(LP: #1884044)
2023-02-25 17:10:17 -05:00
Scott Kitterman b74452d9da Add new dkim.DnsTimeoutError class to report queried domain and selector
along with timeout error from dnspython (LP: #1873449)
2023-02-25 16:44:06 -05:00
Scott Kitterman 233a9699ed Add USE_ASYNC flag to allow async to be disabled when aiodns is
installed (LP: #1954331) - see README.md for details
2023-02-25 16:25:20 -05:00
Scott Kitterman 50a81ab8d6 Add test test_non_utf8 which at least demonstrates not crashing on non UTF-8 data 2023-02-25 15:40:49 -05:00
Scott Kitterman 143e3bffea Fix dknewkey import in dkim/tests/test_dkim_generate.py 2023-02-25 15:39:38 -05:00
Scott Kitterman 5195dbaf3d Add limitations section to README to document current IDN status 2023-02-25 15:38:47 -05:00
Scott Kitterman a35f4a7dd3 Add ChangeLog entry for PKCS#8 private keys 2022-07-31 22:08:13 -04:00
Scott Kitterman f4dff24d68 Add domain validity check for ascii domains (no specials) 2022-01-16 18:21:10 -05:00
Scott Kitterman 6dcaaac712 Provide more specific error message when ed25519 private key is invalid 2021-11-24 15:37:06 -05:00
Scott Kitterman 9c8e46eb5c Fix @param srv_id typos (LP: #1890532) 2020-08-08 17:04:34 -04:00
Scott Kitterman b0bfc115e7 Update dnsplug for DNS Python (dns) 2.0 compatibility (LP: #1888583) 2020-08-08 16:53:08 -04:00
Scott Kitterman d1360c8e25 Add tests for invalid domains, probably not a security issue in the DKIM context, but we should raise errors here. 2020-04-21 20:29:45 -04:00
Scott Kitterman 7848effe4d Update dkimverify (1) to document --index option 2020-04-06 18:16:24 -04:00
Scott Kitterman 5b9dc1253d ChangeLog for index addition in dkimverify 2020-04-06 18:10:54 -04:00
Scott Kitterman 3e16ceac23 Add option to specify index number of signature to verify to dkimverify (Thanks to Nick Baugh for the change) 2020-04-06 18:09:23 -04:00
Scott Kitterman 4b38d9b5ac Merge branch 'addtest' 2020-04-06 17:43:28 -04:00
Scott Kitterman 987ea0a964 Add test case for verifying a message with no signature 2020-04-06 17:43:16 -04:00
Scott Kitterman 095f68d943 - Correct dkim.verify processing to avoid errors when verifying messages
with no DKIM signatures
2020-04-06 00:27:04 -04:00
Scott Kitterman 443aed143a - Correct signature indexing error introduced in 1.0.0 that prevents
verification of multiple signatures in a single message
2020-01-15 11:03:07 -05:00
Scott Kitterman dc2f7f07f2 - dknewkey: On posix operating systems set file permissions to 600 for ed25519 private key files (as is already done for RSA) (LP: #1857827) 2019-12-31 01:17:19 -05:00
Scott Kitterman 73dbcc08a8 Bump version to 1.1 for next feature series development 2019-12-16 15:21:27 -05:00
Scott Kitterman cb32e3e527 - Set minimum dnspython version to 1.16 because previous versions can not
support the timeout parameter (LP: #1856546)
2019-12-16 15:20:01 -05:00
Scott Kitterman e969511184 Update documentation URL in README.md 2019-12-16 15:19:43 -05:00
Scott Kitterman 52f1279754 Set version and release date 2019-12-15 01:26:32 -05:00
Scott Kitterman 5a0824108d Provide specialized error message when signing or verifying ed25519
signatures and pynacl is not installed (LP: #1854475)
2019-12-15 01:12:02 -05:00
Scott Kitterman 6c5f701131 Follow CNAMES when looking up key records when using DNS (pydns)
(LP: #1856421)
2019-12-15 00:42:31 -05:00
Scott Kitterman da3f98e6a1 Set release date 2019-12-09 17:50:37 -05:00
Scott Kitterman 7356ca1b45 Tab/space fix in ChangeLog 2019-12-09 17:49:05 -05:00
Scott Kitterman f9160a9f13 exclude .pyc files from MANIFEST so we con't accidentally ship test artifacts 2019-12-09 17:46:54 -05:00
Scott Kitterman 952621c5b5 Fixed python3 tested versions in README.md 2019-12-09 17:42:56 -05:00
Scott Kitterman 8701e996d3 Make README Mardown (README.md) and use for long_description 2019-12-09 17:36:01 -05:00
Scott Kitterman 166291857a Udpate README for async and tlsrpt support 2019-12-09 17:02:02 -05:00
Scott Kitterman f680dd879b Merge async work into master for 1.0 2019-12-09 09:18:25 -05:00
Scott Kitterman 397ec61717 ChangeLog typo 2019-12-09 09:03:26 -05:00
Scott Kitterman 7173c0cbcc Catch binascii related key format errors (LP: #1854477) 2019-12-08 02:43:57 -05:00
Scott Kitterman c66a014a9f Fix RSAPublicKey in ChangeLog 2019-11-09 13:42:32 -05:00
Scott Kitterman b32c9175c5 Merge branch 'master' of git+ssh://git.launchpad.net/dkimpy 2019-11-08 23:19:35 -05:00
Scott Kitterman 4d2f425ae3 - Support signature verification with SubjectPublicKeyInfo formatted keys
since, although rare, they are RFC 6376 specified (LP: #1851862)
2019-11-08 23:19:17 -05:00
Scott Kitterman 4b48a82de6 - Support signature verification with SubjectPublicKeyInfo formatted keys
since, although rare, they are RFC 6376 specified (LP: #1851862)
2019-11-08 23:14:40 -05:00
Scott Kitterman 5893862e31 New keys and test cases for RSA key format variants like RSAPublicKey 2019-11-08 23:13:26 -05:00
Scott Kitterman 7972217756 DKIM.verify: Refactor to minimize code duplication in dkim.asyncsupport. 2019-11-05 21:36:06 -05:00
Scott Kitterman 9bdb451cd8 DKIM.verify_sig: Refactor to minimize code duplication in dkim.asyncsupport. 2019-11-05 21:10:28 -05:00
Scott Kitterman 3de1dc0362 Refactor load_pk_from_dns to reduce code duplication between async and non-async. 2019-11-05 08:34:13 -05:00
Scott Kitterman 2973852fbb - Add new DKIM.present function to allow applications to test if a DKIM
signature is present without doing validation (LP: #1851141)
2019-11-03 11:57:30 -05:00
Scott Kitterman e8ee183a7f Async version of dkimverify to demonstrate asyncio. 2019-11-02 11:16:13 -04:00
Scott Kitterman 3dda94ca2d Initial async support - works but so much overriding ... 2019-11-02 11:15:36 -04:00
Scott Kitterman 2dc071962d Don't error out on dnsplug tests is DNS/dns isn't installed as preparation for adding async/aiodns support 2019-11-01 17:24:16 -04:00
Scott Kitterman fa93e56fa2 Minor timeout and tlsprt cleanups 2019-11-01 17:22:15 -04:00
Scott Kitterman ebe8fc7c77 Add support for RFC 8460 tlsrpt DKIM signature processing (LP: #1847020) 2019-10-31 20:53:06 -04:00
Scott Kitterman 69049feda1 Add test for l= processing 2019-10-31 20:45:20 -04:00
Scott Kitterman 5487f798ac Documentation updates 2019-10-30 18:52:36 -04:00
Scott Kitterman 1f2597a666 - Add new timeout parameter to enable DNS lookup timeouts to be adjusted
- Drop usage of pymilter Milter.dns in dnsplug since it doesn't support
      havine a timeout passed to it
2019-10-30 18:46:31 -04:00
Scott Kitterman 6db388df39 Ignore unknown service types in key records (LP: #1847020) 2019-10-07 08:34:05 -04:00
Scott Kitterman d1801bb3d5 - Add LICENSE to MANIFEST.in so it is included in the tarball (LP:
#1845318)
2019-09-25 16:20:46 -04:00
Scott Kitterman f8e0cba772 Documentation updates 2019-08-09 11:46:28 -04:00
Scott Kitterman 8365b52ac8 - Fix default canonicalization for DKIM signature verification to be
simple/simple per RFC 6376 (LP: #1839299) (Thanks to Cyril Nicodème for
      the report and a suggested fix)
2019-08-09 09:21:26 -04:00
Scott Kitterman 0019bad372 - Fix linesep setting in arcsign script (LP: #1838262) (Thanks to Gowtham
Gopalakrishnan for the report and the patch)
2019-08-04 17:51:27 -04:00
Scott Kitterman 9904db4e5c Add missing ChangeLog entry 2019-04-14 23:02:04 -04:00
Scott Kitterman 7766ffd7ab Update copyright statements 2019-04-14 22:57:35 -04:00
Scott Kitterman 6fc54ae405 Remove obsolete TODO files 2019-04-14 22:55:21 -04:00
Scott Kitterman ce8e3c8d50 Update README for recent changes 2019-04-14 22:54:27 -04:00
Scott Kitterman a11acd654a Set release date 2019-04-14 22:45:47 -04:00
Scott Kitterman faf2eb330a Update man 1 arcsign for addition of srv_id to options 2019-04-14 22:41:14 -04:00
Scott Kitterman a1b6e73ae1 - Add additional text documenting use of srv_id for ARC signing (LP: #1808301) 2019-04-14 22:21:45 -04:00
Scott Kitterman aa5419b7d9 Fix cv=none processing for initial signature in chain 2019-04-14 22:17:41 -04:00
Scott Kitterman 0ce3775afa Fix the arcsign script so it works with the current API 2019-04-14 22:10:36 -04:00
Scott Kitterman 1bf505995f Clean up obsolete test data 2019-04-13 21:35:43 -04:00
Scott Kitterman 439d66e1e1 Resolve merge conflicts 2019-04-13 21:21:49 -04:00
Scott Kitterman 4c06997d67 Changelog for dkim.fold correction 2019-04-13 21:01:55 -04:00
Scott Kitterman fd3f501787 Update dkim/tests/test_arc.py for changes in dkim.fold 2019-04-13 20:54:13 -04:00
Scott Kitterman 93e647c8de Set maxlen to 71 for subsequent lines since we already have a leading space (LP: #1823006), make doctest demonstrate the problem. 2019-04-13 20:53:16 -04:00
Scott Kitterman 118e854889 - Clarify the crlf does not count towards line length in fold
(LP: #1823008)
2019-04-13 15:05:04 -04:00
Scott Kitterman c1fec1cca8 Delete obsolete .IX macro from man pages 2019-02-08 01:18:12 -05:00
Scott Kitterman 0555cb595d ChangeLog engry for jbfzs/beautifold 2018-12-23 01:57:38 -05:00
Scott Kitterman 25b2eb72b2 Merge remote-tracking branch 'jbfzs/beautifold' 2018-12-23 01:54:39 -05:00
Scott Kitterman 903cc902d9 Changelog and version for starting 0.9.2 2018-12-11 14:36:45 -05:00
Scott Kitterman 84efc4a1cb Release 0.9.1 2018-12-09 14:10:44 -05:00
Scott Kitterman 72f58200e3 - Refactored dknewkey so that it correctly writes out text instead of bytes 2018-12-08 17:32:56 -05:00
Scott Kitterman c3eb342611 Fixed ARC verification to fail is h= tag is present in Arc-Seal, added test, bumped version to start 0.9.1 2018-11-09 19:58:11 -05:00
Scott Kitterman d659c496e5 Set release date 2018-10-30 11:57:17 -04:00
Scott Kitterman 267e62115e - Added missing documentation for timestamp function dkim.arc_sign
(LP: #1800314)
2018-10-30 11:52:43 -04:00
Scott Kitterman 09d4c3d84d Fix @since for add_should_not 2018-10-30 11:40:20 -04:00
Scott Kitterman 8032276b57 Bump version to 0.9.0 since this is now a feature release
- Update oversigned (frozen) header field list to reduce signature
      fragility (removes 'date' and 'subject' fields from being oversigned by
      default - see usage section of README for information on how to restore
      the previous behavior)
    - Added new add_should_not for DKIM/ARC classes to prevent additional
      header fields from being signed
    - Added 'from' to should sign list (to prevent it from not being signed at
      all in the unusual event that 'from' is locally removed from the frozen
      header field set (LP: #1525048)
    - Updates for experimental ARC support:
      - Specified that for ARC, Authentication-Results should not be signed
2018-10-30 11:29:09 -04:00
Scott Kitterman 82d01d8a42 - Raise error when ARC signing if i= instance limit value of 50 is
exceeded
2018-10-30 08:55:32 -04:00
Scott Kitterman cd0ebc1ecb - Updates for experimental ARC support:
- Limit to rsa-sha256, rsa-sha1 not used by ARC and multi-signature
        design TBD
2018-10-30 08:13:06 -04:00
Scott Kitterman 3aaa7e2ab5 Bump versions to 0.8.2 2018-10-30 07:17:10 -04:00