Scott Kitterman
118e854889
- Clarify the crlf does not count towards line length in fold
...
(LP: #1823008 )
2019-04-13 15:05:04 -04:00
Jonathan Bastien-Filiatrault
43c91feac6
Document content debugging parameter.
2018-12-31 09:17:53 -05:00
Jonathan Bastien-Filiatrault
4175d75534
Merge remote-tracking branch 'upstream/master' into content_debugging
2018-12-31 09:10:24 -05:00
Jonathan Bastien-Filiatrault
6b4127f920
Don't insert an extra space at the end of the line when doing a soft fold.
...
Trailing whitespaces are best avoided.
2018-12-12 21:30:56 -05:00
Jonathan Bastien-Filiatrault
2d474d6b04
Do not take the name length into account on the second line when folding.
...
Setting namelen could have no effect, my guess is that this was the
original intention of the code.
This results in more efficient usage of lines.
2018-12-12 21:14:08 -05:00
Jonathan Bastien-Filiatrault
82bef5983b
Don't log message content by default.
...
Right now, it is quite easy to end up logging the whole message in the
log when verifying signatures. This can result in wasted resources
writing the log to disk and increasing memory usage. This can also be
a private data leak if logging is put in DEBUG in a production
environment.
2018-12-12 15:30:47 -05:00
Scott Kitterman
c3eb342611
Fixed ARC verification to fail is h= tag is present in Arc-Seal, added test, bumped version to start 0.9.1
2018-11-09 19:58:11 -05:00
Scott Kitterman
267e62115e
- Added missing documentation for timestamp function dkim.arc_sign
...
(LP: #1800314 )
2018-10-30 11:52:43 -04:00
Scott Kitterman
09d4c3d84d
Fix @since for add_should_not
2018-10-30 11:40:20 -04:00
Scott Kitterman
8032276b57
Bump version to 0.9.0 since this is now a feature release
...
- Update oversigned (frozen) header field list to reduce signature
fragility (removes 'date' and 'subject' fields from being oversigned by
default - see usage section of README for information on how to restore
the previous behavior)
- Added new add_should_not for DKIM/ARC classes to prevent additional
header fields from being signed
- Added 'from' to should sign list (to prevent it from not being signed at
all in the unusual event that 'from' is locally removed from the frozen
header field set (LP: #1525048 )
- Updates for experimental ARC support:
- Specified that for ARC, Authentication-Results should not be signed
2018-10-30 11:29:09 -04:00
Scott Kitterman
82d01d8a42
- Raise error when ARC signing if i= instance limit value of 50 is
...
exceeded
2018-10-30 08:55:32 -04:00
Scott Kitterman
cd0ebc1ecb
- Updates for experimental ARC support:
...
- Limit to rsa-sha256, rsa-sha1 not used by ARC and multi-signature
design TBD
2018-10-30 08:13:06 -04:00
Thomas Ward
4142cd1bd0
lack of Type Hinting for sign and verify functions, lp:1782596
2018-10-27 20:56:05 -04:00
Thomas Ward
a1ca321fa5
PEP8 Blank Lines Style Issues, lp:1782596
2018-10-27 20:53:32 -04:00
Scott Kitterman
f8deb49c0d
Don't error out in Python 3 if include headers is string (LP: #1776775 )
2018-06-16 18:18:45 -04:00
Daniel Hahler
0338aedcc6
Fix bare except statements for expected ImportErrors
2018-06-16 17:28:02 -04:00
Scott Kitterman
0566b9b4c1
- Correctly fold lines at or near the maximum line length (fix folding
...
zero length lines and adding a blank line and adding an exra cr/lf for
lines near max length (LP: #1717576 )
2018-06-16 16:59:39 -04:00
Scott Kitterman
a0ae8c24c5
Detect unknown algorithm in k= tag and raise an appropriate error, vice
...
failing with a traceback
2018-05-18 19:42:46 -04:00
Scott Kitterman
92608e79c4
Simplify error message for bad version (match what Google does)
2018-05-18 18:21:32 -04:00
Scott Kitterman
bec6869c78
Detect incorrect version in DKIM public key record (LP: #1763815 )
2018-05-18 18:17:30 -04:00
Scott Kitterman
43e56378c1
- Return an empty list (as expected) when no AR headers are found or no AR
...
arc stamps are found and the chain terminated (LP: #1748146 )
2018-02-11 19:39:51 -05:00
Scott Kitterman
3209be62d1
Fix a= tag in ed25519 signatures (thanks to Jeremy Harris)
2018-02-05 11:28:05 -05:00
Scott Kitterman
3138f90077
Updated copyright statements
2018-02-05 04:05:41 -05:00
Scott Kitterman
077bf4813c
Self consistent, but not externally verified ed25519 based on draft-ietf-dcrup-dkim-crypto-08
2018-02-05 03:53:03 -05:00
Scott Kitterman
10e12c60d8
- Fix unbound local variable error when processing signatures with an x
...
tag, but no t tag (LP: #1739637 )
2017-12-21 16:35:42 -05:00
Scott Kitterman
44146ed2de
Fix arcverify tag requirements (LP: #1710312 )
2017-11-18 23:34:50 -05:00
Scott Kitterman
04b1a8dddf
Reapply lost ARC updates
2017-11-18 20:38:47 -05:00
Scott Kitterman
01a2f77481
Revert a bunch of rsafp stuff now that DCRUP isn't going to do rsafp
2017-11-18 20:17:35 -05:00
Scott Kitterman
3f9660716e
Delete unused sys import
2017-07-28 01:32:25 -04:00
Scott Kitterman
c37fcf55e8
Merge Gene Shuman updates for ARC
2017-07-28 01:30:52 -04:00
Gene Shuman
17d7c39155
Minor cleanup for ARC
2017-07-27 13:12:57 -07:00
Gene Shuman
45dbdeabcf
Updates for changes in handling of ARC failures. Added support for merging AR headers for AAR creation
2017-07-26 13:09:32 -07:00
Scott Kitterman
c7782addd5
- Add generation of rsafp DKIM signatures per
...
draft-ietf-dcrup-dkim-crypto-02
2017-06-23 18:29:37 -04:00
Scott Kitterman
38664fab55
Check and update references to RFC 4871 to refer to RFC 6376.
2017-05-31 02:01:22 -04:00
Scott Kitterman
e14a4f3539
- Fixed problem with header folding that caused the first line to be
...
folded too long (Updated test test_add_body_length since l= tag is no
longer at the beginning of a line
2017-05-30 12:11:15 -04:00
Gene Shuman
4079b79abc
Fix byte casting issues & typos
2017-03-01 16:48:32 -08:00
Gene Shuman
7456fffcea
python3.4 cant interpolate tuples into byte strings
2017-02-27 16:16:20 -08:00
Scott Kitterman
1ded8e9171
Pre-release version bumps and documentation updates.
2017-01-23 12:18:26 -05:00
Gene Shuman
ac6d9a6bb3
refactoring/integrating ARC code
2017-01-17 13:20:20 -08:00
Scott Kitterman
697d55d057
Work in progress to better integrate ARC into dkimpy
2016-11-12 23:18:48 -05:00
Scott Kitterman
baf8d8e417
Commit ARC changes from Brandon Long <blong@google.com>
...
- These will need some rework to integrate into the packcage - we do not want to ship two modules
2016-10-14 16:37:56 -04:00
Stuart D Gathman
01541a3c36
Fix and test case for case insensitive subdomain matching.
2015-08-06 22:24:34 -04:00
Stuart D Gathman
c6523a3d72
Merges some of the changes from Diane Trout to pass unit tests in python 2/3.
2015-02-21 19:34:20 -05:00
Stuart D. Gathman
94c5e093bb
Preceding wasn't actually included in testing. :-( Fix typo.
2013-07-09 19:22:14 -04:00
Stuart D. Gathman
ed6a7f5454
Allow x= with no t= (it is legal)
2013-07-09 16:51:53 -04:00
Scott Kitterman
fd0caddf16
Update for version 0.5.4.
...
Fixed error in FWS regular expression that cause some valid signatures
fail verification (Thanks to Peter Palfrader (weasel) for the patch)
2013-06-09 22:43:29 -04:00
Scott Kitterman
a5e10c1a98
- Change dkimsign.py to sign the default (recommended) set of headers
...
instead of all headers
2013-04-29 01:01:00 -04:00
Stuart D. Gathman
f4bbd8af11
add missing exception variable
2013-04-26 20:47:49 -04:00
Stuart D. Gathman
d7d0979a7e
Report public key too small only when message otherwise passes.
2012-10-27 11:23:05 -04:00
Stuart D. Gathman
5f2024fdf8
Test case for tab in FWS bug. Use minkey=512 for test cases.
2012-10-27 10:48:29 -04:00